Problem with Race Condition on Time Picker clock face #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dition Working model of the race condition in stack being resolved the dirty…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am having a problem with the face on the Time Picker component. I tried to post a bug about this but you guys could not reproduce so it got closed. However, I have since figured out how to reproduce it. Our site is large and there is a lot to load so all you need is a load time of longer than 1 second or any list longer than 100 remote items being loaded and the bug will happen. I have included a zipped .mov file that shows me reproducing this bug just to show you it exists.
You open the Time Picker, press once on any hour position on the clock face, the dialog proceeds forward into choosing the minutes and yet the hour has not moved from it's initial position.
It only seems to happen on the very first click when the Time Picker has been opened. If you open it and instead click+drag in any direction this bug does not occur. It also does not occur if (after being taken to the minutes selection phase) you return back to the hour selection phase and re-select the option you wanted. I believe it's a simple race condition happening here and so that's why I added that awful quick fix. This fix is less about the 200 milliseconds wait time and more about popping this event from the next position in the Call-stack to the end.
The code I added is really dirty as a quick fix so it's mostly just to bring your attention to the problem in some way other than just as a closable issue ticket. Hopefully you can help me to resolve this issue asap since I use this repository heavily and would like to not require self-hosted NPM packages if possible.
bug1-edit.mov.zip