-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Migrated the docs to Docusaurus(Issue #923) #925
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sikehish thank you for the PR ✨
let's do these first set of changes 👇
Sure! I will. |
Hi @ad1992. I didnt understand the options part. Do you want a single options file instead of a directory? Also,I didnt understand the "Move this to under react tags" comment . What should be moved? |
Hi @ad1992, Ive made all the changes that you had specified. You can try it out and let me know if any changes are to be made. |
@sikehish there is a nested |
Hi @ad1992 I'm not sure if that can be done, cuz the nested docs dir is configured to serve the .md files. I can club and merge it into the roots dir, but then that might make it more unstructured, as we have src directory, static directory and a host of other files and images in the root level docs directory |
I can rename the directory to something more meaningful if need be, or if you think that clubbing and merging at the root level docs directory is required, then I'll get started with it. |
@sikehish Its best we merge both the docs into the single root level docs directly so let's do that. |
Sure, I'll give that s shot and update very soon |
@ad1992 I've spent quite some time trying to have all the docs(.md files) under the root docs directory, and Ive tried toying with all the configs possible, but that isnt possible. I checked the docs, and as per the docs, we need to have the docs directory. I felt like I pulled it off but I realized that the built in configs expect the devs to include docs dir. |
Hi @sikehish apologies for not getting back on this PR. There have been changes in docs recently, do you want to update this PR with latest changes and then we can merge it sooner this week? |
Hi. Sure, I'd love to do that. Do I contine with the same approach? Or anything that you'd want me to keep in mind? |
Both the docs would ideally be merged into one, but as you mentioned that looks tricky now so in that case let's rename the docusaurus docs folder to |
Hi @sikehish checking if you would be picking this up ? |
Hi @ad1992 , I'd love to take this up. Can we decide on a deadline? |
The sooner the better :) Would be great if you could push the changes in the coming week. |
Sorry for the delay :( Im getting started with it right now |
Hi @ad1992 . Ive updated docusaurus. Let me know if any other changes are to be made. |
@sikehish i think the changes from |
Apologize for the inconvenience. Ive pushed the changes |
I've migrated it to Docusaurus(v2). I've also added a custom favicon, and also made it readable. It can be found in the react-tags-docusaurus directory.