New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Android): skip sending event when onResults/onPartialResults receive empty array #493

Open

aladine wants to merge 3 commits into react-native-voice:master from aladine:master

aladine commented Apr 3, 2024 •

edited

Context:

In onResults/onPartialResults sometimes we get empty string and on ReactNative application, we don't need empty string from voice response.
To save the roundtrip network call via the bridge, I think it is better to filter out empty string from the array sending via event.
Many dependencies are outdated and worth to upgrade.

Proposed changes:

Add empty string check before pushing result to array in onResults/onPartialResults
Update gradle to 8.3 when open the project as a stand alone project in IDE
Replace jcenter to mavenCentral since jcenter is deprecated
Update com.android.support:appcompat to androidx equivalent dependency, the default version is 1.2.0

Dan Tran added 3 commits

April 3, 2024 14:42


          feat(Android): skip sending event when onResults/onPartialResults rec…

62326fd

…eives empty array + update android dependencies


          feat: update version for @expo/config-plugins in package.json since 2…

797857b

….0.4 is too old


          fix: revert the change in package.json

0d57294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment