Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation about customMapStyles being only effective with Google provider #4950

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gkpo
Copy link

@gkpo gkpo commented Feb 1, 2024

Does any other open PR do the same thing?

No

What issue is this PR fixing?

customMapStyle has no effect when using Apple maps as provider #4948

How did you test this PR?

This is a change in the Readme.

@salah-ghanim
Copy link
Collaborator

@gkpo would be nice if you update the documentations instead in two ways:

  1. the section title: Customizing the map style could have (Provider: GoogleMaps) as part of the title
  2. mention that this is a depricated way of customyzing style instead using google maps cloud and using mapId is the way to go (this feature was introduced recently but not well documented and doesn't work yet for iOS).

@@ -265,7 +265,7 @@ render() {
}
```

For iOS, in addition to providing the `mapStyle` you will need to do the following
This option only works with the Google provier. So for iOS, in addition to providing the `mapStyle` you will need to do specify the provier with the following:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: should be "Google provider"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants