Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added missing cancel event for web platform #2291

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bhagi-srinivasu-swiggy
Copy link

Thanks for submitting a PR! Please read these instructions carefully:

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the main branch, NOT a "stable" branch.

Motivation (required)

What existing problem does the pull request solve?
Currently, the web platform doesn't handle the cancel event which is causing different behaviours in platforms.
I have added the eventListener to cancel event for web platform.

Test Plan (required)

Test Plan: Ran locally.

assets: [],
};

if (callback) callback(result);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to resolve the promise also

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants