Fix issue 2119: make live photo identifier more generic #2236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue 2119
We are running into the problem outlined in issue 2119 where there is a "Could not find image file..." error on iOS when selecting images that are on iCloud but not yet fully synced to the user's device.
I found by updating the live photo identifier to be more generic (rather than it explicitly being "public.jpeg") this resolved the issue.
Please note: I am a React Native / Javascript developer, and not by any means a native iOS / Objective C developer. To reach the solution in this PR I referenced the code in this PR, and added the least amount I could to resolve the issue. Someone with more native iOS experience may be able to suggest a more robust solution to the issue.
Test Plan
(Requires testing with two devices logged into the same iCloud account)