Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2119: make live photo identifier more generic #2236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samcodefish
Copy link

@samcodefish samcodefish commented Nov 9, 2023

Motivation

Issue 2119

We are running into the problem outlined in issue 2119 where there is a "Could not find image file..." error on iOS when selecting images that are on iCloud but not yet fully synced to the user's device.

I found by updating the live photo identifier to be more generic (rather than it explicitly being "public.jpeg") this resolved the issue.

Please note: I am a React Native / Javascript developer, and not by any means a native iOS / Objective C developer. To reach the solution in this PR I referenced the code in this PR, and added the least amount I could to resolve the issue. Someone with more native iOS experience may be able to suggest a more robust solution to the issue.

Test Plan

(Requires testing with two devices logged into the same iCloud account)

  • Take a photo on device A
  • Use the example app on device B logged into the same iCloud account
  • Select the image synced over with iCloud (without making any edits)
  • Without this change you'll get the "Could not find image file..." warning. With this change, you'll retrieve the image as expected.

@efstathiosntonas
Copy link

Hi folks, any updates on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants