Fix IOS video dimensions #2211
Open
Fix IOS video dimensions #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this solution on one of this package's issues and it worked perfectly with me, so instead of just patching it this can be a fix for everyone.
Motivation (required)
When picking a MOV video from the camera picker or photos library, the picked dimensions are always in landscape mode even if you picked a portrait video, this PR fixes this behavior and returns the correct dimensions based on the correct mode.
Test Plan (required)
Just try to record a video using the library in portrait mode and read the dimensions.
1- Before this PR: 1920w * 1080h.
2- After this PR: 1080w * 1920h.