Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve the original filename on android #2209

Merged
merged 1 commit into from Sep 7, 2023
Merged

Conversation

Johan-dutoit
Copy link
Collaborator

BREAKING CHANGE: changed the way the name is retrieved

BREAKING CHANGE:  changed the way the name is retrieved
@Johan-dutoit Johan-dutoit added the Android Platform: Android label Sep 7, 2023
@Johan-dutoit Johan-dutoit merged commit c51a810 into main Sep 7, 2023
1 check passed
@Johan-dutoit Johan-dutoit deleted the feat/original-path branch September 7, 2023 07:59
Johan-dutoit pushed a commit that referenced this pull request Sep 7, 2023
# [6.0.0](v5.7.0...v6.0.0) (2023-09-07)

### Features

* **android:** orignal file path ([#2209](#2209)) ([c51a810](c51a810))

### BREAKING CHANGES

* **android:** changed the way the name is retrieved

Co-authored-by: Johan du Toit <johdutoit@shoprite.co.za>
Johan-dutoit added a commit that referenced this pull request Sep 7, 2023
BREAKING CHANGE:  changed the way the name is retrieved
Johan-dutoit pushed a commit that referenced this pull request Sep 7, 2023
# [6.0.0](v5.7.0...v6.0.0) (2023-09-07)

### Features

* **android:** orignal file path ([#2209](#2209)) ([c51a810](c51a810))

### BREAKING CHANGES

* **android:** changed the way the name is retrieved

Co-authored-by: Johan du Toit <johdutoit@shoprite.co.za>
Johan-dutoit pushed a commit that referenced this pull request Sep 7, 2023
# [6.0.0](v5.7.0...v6.0.0) (2023-09-07)

### chore

* **release:** 6 was burnt ([#2210](#2210)) ([352b31f](352b31f))

### Features

* **android:** orignal file path ([#2209](#2209)) ([7086e95](7086e95))

### BREAKING CHANGES

* **release:** use v 7
* **android:** changed the way the name is retrieved
String originPath;
if (uri.getScheme().contains("content")) {
originPath = getFilePathFromContent(uri, context);
uri = getAppSpecificStorageUri(uri, context);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a second cached file to be created which isn't returned. Issue created here: #2271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Platform: Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants