feat: Add openCamera web support #2105
Open
+172
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoguzmana
reviewed
Apr 8, 2023
There was a problem hiding this comment.
Great work on this @jardelbordignon! great to see some effort to increase web support 🚀
How does this look like? Can we add some screenshots in the PR or a usage example in the example app? (not sure if there are changes needed to make it work in the example app)
|
Hey! I appreciate the work of maintaining the project.
The way to use it is exactly the same but in a react-native-web app, just follow the official documentation.
|
mateoguzmana
approved these changes
Apr 10, 2023
| @@ -0,0 +1,5 @@ | |||
| /* eslint-disable @typescript-eslint/ban-types */ | |||
There was a problem hiding this comment.
Suggested change
| /* eslint-disable @typescript-eslint/ban-types */ |
Is this needed? I removed it locally and TS transpiles correctly without errors
There was a problem hiding this comment.
This was to suit my lint setup, but it can be removed.
|
I'd happily merge this is the example app can be updated to run this on web. |
|
Is this ready to merge? |
MrMole96
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test the functionality on the web just create a react-native-web app and use the openCamera function as per the official documentation