fix: iOS launchCamera opens camera with black background (#2024) #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns camera with black background (react-native-image-picker#2024)
NilPuig
approved these changes
Jul 8, 2023
superaaronhu
approved these changes
Aug 10, 2023
|
Thanks for the reviews and approvals, and I'm glad to hear it's working. Wish I could merge, but unfortunately it's still needing a review from someone with write access. I'll be more than happy to see this merged. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch, NOT a "stable" branch.Motivation (required)
Fixes #2024
Test Plan (required)
See #2024 for replication steps. Effectively, no new code has been written, but instead, code has been moved from launchImagePicker that specifically related to camera. This also fixes the issue where the camera was being launched without permission. The below image shows the result of clicking "Take Image" and not allowing the permission.
