Switch to yarn #84
Merged
Switch to yarn #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwdata
commented
Oct 27, 2016
| @@ -45,6 +45,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "classnames": "^2.2.5", | |||
| "eslint": "3.7.1", | |||
There was a problem hiding this comment.
there's some comma-dangle hick hack going on ... so we stick to that version for now
There was a problem hiding this comment.
@fspoettel don't you just thumbs up, give me a real review and approve!!! 😄
There was a problem hiding this comment.
i thought i did, looks like i did not push the Approve button hard enough
There was a problem hiding this comment.
it's ok, just make sure you are fully concentrated next time. It's important to stay focused when pressing buttons!
fspoettel
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently one interesting discussion ongoing: yarnpkg/yarn#570
the behaviour at the moment is that when a normal
yarn installis running, it automatically generates and updates theyarn.lockfile within the specified version range from thepackage.jsonSo in order to reproduce the correct dependencies always purely from the lock file it's important to add
--pure-lockfileto theyarn installcommand ... I hope they change that. But just in case people are wondering here why the hell the yarn.lock changes after an install.