Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

fix: add source map files to builds #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add source map files to builds #200

wants to merge 1 commit into from

Conversation

gnowland
Copy link

@gnowland gnowland commented Dec 6, 2022

Description

Fixes #100, #167, #176, #179

Adding TSConfig option inlineSources fixes "Failed to parse source map" webpack warning. Adds nominal weight to packages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Built packages locally, referenced local packages in my application package.json (i.e.

"dependencies": {
  "@react-keycloak/web": "file:../react-keycloak/packages/web"`
}

...then executed npm start in my application -- no failed to parse source map (or other) warnings were shown.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gnowland gnowland closed this by deleting the head repository Dec 6, 2022
@gnowland
Copy link
Author

gnowland commented Dec 6, 2022

Unintentionally closed 🙃

@gnowland
Copy link
Author

gnowland commented Dec 6, 2022

@panz3r I'm sure you're aware of the @types TS errors building the package, happy to assist resolving those so we can get this released ASAP.

@milosrs
Copy link

milosrs commented Dec 29, 2022

@panz3r please merge this. It's a really small changeset

@douglaszaltron
Copy link

up

@karastras
Copy link

Hello !
@panz3r , i realy need this fix. When do you think you will merge this pull request ?
Thx

@dejwsz
Copy link

dejwsz commented Jan 20, 2023

We need it too here, please merge.

@InumanSoul
Copy link

Please merge this fix!

Copy link

@InumanSoul InumanSoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the warnings about source map

@msebastiao-maxcapital
Copy link

Hello !
@panz3r , we really need this fix. Please merge this.
Thx

@estani
Copy link

estani commented Jan 30, 2023

+1 But I think this repo has being dead for some time. Better fork it and apply the changes or try a different one (see https://github.com/dasniko/keycloak-reactjs-demo)

@thanhdat1902
Copy link

Can you please merge this PR. We all need this.

@PaulaDianaCuc
Copy link

Can you please merge this fix? We really need this

@farisdurrani
Copy link

@panz3r what's the status of this PR?

Copy link

@msebastiao-maxcapital msebastiao-maxcapital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok, please merge

@martinLeht
Copy link

Is anyone maintaining this repo? We all need this fix so bad and this has been open for a while now...

@msebastiao-maxcapital
Copy link

@gnowland please can you merge this?

@gnowland
Copy link
Author

gnowland commented Apr 3, 2023

@gnowland please can you merge this?

@msebastiao-maxcapital I’m not a maintainer so I am not able to merge PRs.

I assume at this point that @panz3r is no longer maintaining this repo.

@msebastiao-maxcapital
Copy link

msebastiao-maxcapital commented Apr 3, 2023

@bring2dip please, can you merge this, or make us contributors?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with sourcemaps in TypeScript project