clarify testing of drag-drop interaction for components #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zargold
reviewed
Oct 5, 2016
| @@ -130,6 +130,10 @@ it('can be tested with the testing backend', function () { | |||
| // Find the drag source ID and use it to simulate the dragging operation | |||
| var box = TestUtils.findRenderedComponentWithType(root, Box); | |||
| backend.simulateBeginDrag([box.getHandlerId()]); | |||
|
|
|||
| // Incase your component is acting both as a DragSource and DragTarget | |||
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gaearon, thanks a ton for this epic library, and the fantastic docs. I found that there's a scope for adding some clarification in the testing for drag-drop interaction section. I ran into the issue and spent a few hours debugging it - only to find a super helpful comment by @yannisbarlas in #236 (comment).
I believe if it'll be useful to others, but feel free to disregard it if you don't agree 馃憤
Thanks again for your work!