fix NODE_ENV interpolation in vite production build #3547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received an error in my project:
I'm using vitejs toolchain and seems like it replaces
process.env.NODE_ENV
string withtrue/false
value during the build, but it doesn't replaceprocess.env['NODE_ENV']
(see source).I got the problem because in my particular case one of the modules are declares
process
variable (so it's not an undefined) butvitejs
doesn't specifyprocess.env
.I'm suggesting to replace current check with
process.env.NODE_ENV === 'production'
. In this casevitejs
can easily replace this string with particular value during the build.This is should be safe update because there are plenty of popular packages that do the same check:
If you will search for
process.env.NODE_ENV
in node_modules you will see plenty of search results:But
process.env['NODE_ENV']
only appears in react-dnd: