Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touch backend #240

Closed
wants to merge 1 commit into from
Closed

touch backend #240

wants to merge 1 commit into from

Conversation

longlho
Copy link

@longlho longlho commented Jul 20, 2015

For #16

I'm trying to use this repo for 1 of my apps so I did an implementation based on your POC. I'm still ironing out some of the details in remove touch event listeners properly.

@longlho longlho force-pushed the master branch 2 times, most recently from aeb5d41 to b37f01f Compare July 20, 2015 05:05
@gaearon
Copy link
Member

gaearon commented Jul 20, 2015

Wow, that's awesome! Let me know when it's more production ready and I can help you test it if you'd like.

@longlho
Copy link
Author

longlho commented Jul 20, 2015

yup definitely :) It's getting reviewed now

@nickdima
Copy link

@longlho what's the status on this?

@longlho
Copy link
Author

longlho commented Aug 21, 2015

@nickdima this is the final version :) we're using it right now in prod.

ping @gaearon

@gaearon
Copy link
Member

gaearon commented Aug 21, 2015

Wow, great to hear that! I'm still busy with other stuff but should be able to allocate some time in late September to go through issues and merge this as well.

@sobrinho
Copy link

sobrinho commented Sep 9, 2015

You have to add this line to src/index.umd.js :shipit:

export * as Touch from './backends/Touch';

@sobrinho
Copy link

sobrinho commented Sep 9, 2015

Guys, what about hybrid devices that supports mouse and touch events?

I didn't in fact read the source yet but we should be listening to both events or have a "multi" back-end that supports both.

Wdyt?

@longlho
Copy link
Author

longlho commented Sep 9, 2015

That's definitely a possibility but will be pretty tricky IMO and will require stopPropagation at the right stage. I haven't got time to tackle this use case yet.

@longlho
Copy link
Author

longlho commented Sep 9, 2015

@sobrinho just fixed the dist :)

@gaearon gaearon mentioned this pull request Sep 13, 2015
@gaearon
Copy link
Member

gaearon commented Sep 17, 2015

Hey, thanks for all the work.

I'm closing this issue because I'm confident I want the backends to be in separate repos and be published on NPM (with a peerDependency on React DnD's current major version). I'm going to publish HTML5 backend separately, too.

If you publish touch backend on NPM, please link to it in this thread. I propose that we use react-dnd-*-backend naming scheme, e.g. react-dnd-mouse-backend.

@longlho
Copy link
Author

longlho commented Sep 24, 2015

gotcha 👍

@longlho
Copy link
Author

longlho commented Oct 5, 2015

@gaearon just an update on this. Touch backend's been published on npm: https://www.npmjs.com/package/react-dnd-touch-backend

@gaearon
Copy link
Member

gaearon commented Oct 16, 2015

Awesome, I linked to it from README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants