targetId undefined on initial render being passed to parseRoleFromHandlerId #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous change set targetId/sourceId was changed so that it could be passed undefined to internal functions. Not all functions were changed to check for this change causing parseRoleFromHandlerId to reference an undefined variable. Signed-off-by: Chris Frank <cfrank@redventures.com>
cfrank
changed the title
|
Thanks for the PR! I modified it slightly on my end, but I'll release it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1245
In a previous change set targetId/sourceId was changed so that it could
be passed undefined to internal functions. Not all functions were
changed to check for this change causing parseRoleFromHandlerId to
reference an undefined variable.
Signed-off-by: Chris Frank cfrank@redventures.com