Fix interference with drop events of native drag-n-drop #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes interference with drop events of native drag-n-drop (for example for file uploads with Dropzone). See react-dnd#457 (comment)
|
Thanks for the contribution! I'm trying out the modification on my end. |
|
If you'd like me to merge this PR so you can get credit for this contribution in GitHub, could you limit the PR to just the HTML5Backend file and delete the line in question instead of commenting it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments out
e.dataTransfer.dropEffect = 'none'for native itemsThis fixes interference with drop events of native drag-n-drop (for example for file uploads with Dropzone). See #457 (comment)