New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preventDefault for non-Tab, const keys in onKeyDown #2057
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Let's also add a test to https://github.com/airbnb/react-dates/blob/master/test/components/DayPicker_spec.jsx#L240-L273 for this.
Will do! Sorry I'm hitting a bit of a first-time-contributor bump... I develop on Windows so the script commands are giving me a tough time actually running tests/building locally... putting this PR up I honestly left it up to the CI to get it there... I typically would employ something like |
No worries at all; indeed that command is not Windows-compatible. I'll fix it in master shortly, and then you can rebase and should be unblocked. |
…sign`, `object.values`, `react-moment-proptypes`, `react-outside-click-handler`, `react-portal`
Instead of pushing it to master, I prepended to this PR, so you should be set (reset your local branch to the pushed changes) |
1a472b1
to
60719e1
Compare
Thanks...@ljharb sheesh, now it's stumbling on installing the peers for enzyme-adapter-react... |
@JohnC-80 what versions of node/npm are you using? |
@ljharb |
hmm - that should be using |
@ljharb |
Looking at the rest of the code, I see the |
@JohnC-80 hmm, I'm not actually sure :-/ it seems like it's worth doing a lot of manual testing here. |
Should resolve #2055