Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add marks dot classname #842

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

howiepu
Copy link

@howiepu howiepu commented Aug 31, 2022

I need to do something special with the dot for marks, but I don't have a class name for marks, so I think it's worth adding that.

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slider ❌ Failed (Inspect) Apr 20, 2023 8:44am

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #842 (fb86e14) into master (5924005) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fb86e14 differs from pull request most recent head 7a3fe19. Consider uploading reports for the commit 7a3fe19 to get more accurate results

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          13       13           
  Lines         535      540    +5     
  Branches      147      150    +3     
=======================================
+ Hits          534      539    +5     
  Misses          1        1           
Impacted Files Coverage Δ
src/context.ts 100.00% <ø> (ø)
src/Handles/Handle.tsx 100.00% <100.00%> (ø)
src/Slider.tsx 100.00% <100.00%> (ø)
src/Steps/Dot.tsx 100.00% <100.00%> (ø)
src/Steps/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@howiepu howiepu changed the title feat(dot-style): add marks dot classname perf: add marks dot classname Aug 31, 2022
@yoyo837
Copy link
Member

yoyo837 commented Apr 15, 2023

Docs and test case please.

src/Steps/Dot.tsx Outdated Show resolved Hide resolved
src/Steps/Dot.tsx Outdated Show resolved Hide resolved
src/Steps/index.tsx Outdated Show resolved Hide resolved
src/Steps/index.tsx Outdated Show resolved Hide resolved
@MadCcc
Copy link
Member

MadCcc commented Apr 20, 2023

Prefer to have classNames: { markedDot: string } for Slider, not to add className by default.
Then you can use like this:

<Slider classNames={{ markedDot: 'custom-dot' }} />

<Dot
prefixCls={prefixCls}
className={classNames({
[`${prefixCls}-marks-dot`]: isMarksDot,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[`${prefixCls}-marks-dot`]: isMarksDot,
+markedDot,

@MadCcc An additional?

Copy link
Member

@MadCcc MadCcc Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, current design do not need a className to style dot with mark. It's better to append customized className to this element.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll write it down when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants