feat: add previous and next toggle to toolbar #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
afc163
reviewed
Mar 19, 2024
src/Preview.tsx
Outdated
Comment on lines
28
to
29
| onSwitchLeft?: () => void; | ||
| onSwitchRight?: () => void; |
There was a problem hiding this comment.
前一个、后一个跟 active 语义上应该是没有关系的，我觉得 onSwitchPrev、onSwitchNext 好点
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 15 15
Lines 457 469 +12
Branches 128 134 +6
=======================================
+ Hits 456 468 +12
Misses 1 1 ☔ View full report in Codecov by Sentry. |
madocto
changed the title
onSwitchPrev and onSwitchNext to toolbar
madocto
changed the title
onSwitchPrev and onSwitchNext to toolbaronSwitchPrev and onSwitchNext to toolbar
madocto
changed the title
onSwitchPrev and onSwitchNext to toolbaronActivePrev and onActiveNext to toolbar
zombieJ
reviewed
Apr 9, 2024
README.md
Outdated
| @@ -180,6 +182,8 @@ type TransformAction = | |||
| zoomInIcon: React.ReactNode; | |||
| }; | |||
| actions: { | |||
| onActivePrev?: () => void; | |||
There was a problem hiding this comment.
type OnActive = (offset: number) -> void;不需要前后，一个就够了。提供 offset 作为偏移量。这样如果是未来一次性翻10个也是同一个 API
madocto
force-pushed
the
feat-left-right-toolbar
branch
from
5d89bcf
to
4a36f82
Compare
|
madocto
changed the title
onActivePrev and onActiveNext to toolbar
zombieJ
reviewed
May 15, 2024
src/common.ts
Outdated
| @@ -11,3 +11,7 @@ export const COMMON_PROPS: (keyof Omit<ImageElementProps, 'src'>)[] = [ | |||
| 'useMap', | |||
| 'alt', | |||
| ]; | |||
|
|
|||
| export const DEFAULT_PREV_OFFSET = -1; | |||
zombieJ
reviewed
May 15, 2024
src/Preview.tsx
Outdated
| setEnableTransition(false); | ||
| resetTransform('next'); | ||
| onChange?.(current + 1, current); | ||
| if (!Number.isInteger(offset) || offset === 0 || position < 0 || position > count - 1) { |
There was a problem hiding this comment.
这个时序看起来有问题，上面已经拿 offset 做计算了，下面再判断 offset 没什么必要。只要看 position 是否是合法的在范围内即可
zombieJ
reviewed
May 15, 2024
src/Operations.tsx
Outdated
|
|
||
| const toolsNodeMap = new Map<ToolType, React.ReactNode>() | ||
|
|
||
| const toolsNode = tools.map(({ icon, onClick, type, disabled }) => { |
There was a problem hiding this comment.
不需要遍历生成，直接搞个 renderOperation 方法就行了。以前的 tools 搞个数组看起来也没什么必要。
madocto
force-pushed
the
feat-left-right-toolbar
branch
from
c9dcc70
to
c080730
Compare
madocto
force-pushed
the
feat-left-right-toolbar
branch
from
c080730
to
b6c0b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ant-design/ant-design#47948