Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7367
The cause of the issue is simply that we don't consider the
Chem.CXSmilesFields.CX_BOND_ATROPISOMER
SMILES extension when computing the registration hash. Fixing the issue is as simple as adding it to the flags we use.While working on this, I noticed that
wedgeBondsFromAtropisomers()
is missing a check for ring info, since bothWedgeBondFromAtropisomerOneBond2d()
andWedgeBondFromAtropisomerOneBond3d
require ring info and callminBondRingSize()
.