Allow disabling output of dative bonds to SMILES #7384
Conversation
… to the SMILES add forms of GetAtomSmiles() and GetBondSmiles() that take SmilesWriteParams
|
Why not off by default? |
Firstly because that would be serious change in behavior. Secondly because I believe that it, like the other SMILES and SMARTS extensions the RDKit supports, are valuable and useful additions. |
| //! \overload | ||
| inline std::string ChemicalReactionToRxnSmarts(const ChemicalReaction &rxn) { | ||
| SmilesWriteParams params; | ||
| params.canonical = false; |
There was a problem hiding this comment.
This is going to take a while to go through, can you give me the nickel tour? Why do we need canonical=False for instance?
There was a problem hiding this comment.
because it's SMARTS and we can't do sensible canonicalization with SMARTS
|
@bp-kelley do you have time to finish this review so that we can get this one in next week's release? |
@bp-kelley : @ptosco did a review, so don't worry about this one. |
Also adds the option to write dative bonds to SMILES as coordinate bonds.
Fixes #7372
Still needs: