Add support for vcpkg #6794
Open
Add support for vcpkg #6794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SPKorhonen it's going to take me a while to review this because of the upcoming RDKit release and the fact that this touches a bunch of build-system files |
|
No worries. I can keep syncing this branch with the master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal modifications to enable usage of vcpkg dependencies when building RDKit. Closes issue #6781.
Few implementation details:
@greglandrum Could you give me guidance on how to add the vcpkg support to documentation? Should I add instructions for windows build instructions?