RDKDEV-680 xdial code quality issues #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomasz-karczewski-red
commented
Apr 20, 2023
tomasz-karczewski-red
commented
- most of the compilation warnings should be gone (there are some that are caused by included headers, mostly Thunder headers, these can't be easily fixed without changes to Thunder framework)
- the memory leaks should be gone
- it should be possible to compile xdial with gssdp >= 1.2
- Fixes compilation with gssdp-1.2.3[1]
- Fix compilation error:
too many arguments to function 'gssdp_client_new'
[1] http://errors.onemw.net/Errors/Details/129057/
strdup'ed memory was never released (as confirmed with valgrind)
compilation warnings removed
.gitignore updated
Second compilation failed on builds with gssdp-1.0
Adressed warnings:
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/plat/rtcache.cpp:47:95: warning: format '%s' expects argument of type 'char*', but argument 2 has type 'std::__cxx11::string* {aka std::__cxx11::basic_string<char>*}' [-Wformat=]
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/plat/rtcache.cpp:52:95: warning: format '%s' expects argument of type 'char*', but argument 2 has type 'std::__cxx11::string* {aka std::__cxx11::basic_string<char>*}' [-Wformat=]
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/gdial-ssdp.c:162:3: warning: format not a string literal, argument types not checked [-Wformat-nonliteral]
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/gdial-ssdp.c:163:3: warning: format not a string literal, argument types not checked [-Wformat-nonliteral]
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/main.c:197:3: warning: implicit declaration of function 'gdial_plat_register_friendlyname_cb' [-Wimplicit-function-declaration]
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/main.c:199:3: warning: not enough variable arguments to fit a sentinel [-Wformat=]
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/main.c:200:3: warning: not enough variable arguments to fit a sentinel [-Wformat=]
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/main.c:201:3: warning: not enough variable arguments to fit a sentinel [-Wformat=]
/home/mikolaj.staworzynski/projects/eos2008c_20220922/onemw/onemw-src/onemw-xdialserver/server/main.c:262:13: warning: passing argument 1 of 'free' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
TODO: check - Conflicts:
server/main.c
This removes most of xdial warnings; remaining ones are either caused by libsoup/glib version discrepancies or strange redefinitions of 'EXTERNAL' in couple wpeframework files
|
Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-3645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.