Omwappi 1545 xdial server patches 2402 sprint #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to specify the amount of time xdial server waits for rtremote status update resposes with XDIAL_WAIT_FOR_RTREMOTE_STATE_RESPONSE_MS. This can be used to make sure that up-to-date application states are returned (instead of cached ones)
- if app instances are created outside of xdial, we might still be missing GDialApp instance. - do not fetch app state asynchronously in case xdial is configured to wait for remote state responses anyway - if current app state is 'stopped' or 'hidden' always return 201 on POST requests
|
@viveksinghnarwaria for this component build failing due to this header<rtRemoteEnvironment.h> can be solved by this gerrit change https://code.rdkcentral.com/r/c/rdk/components/generic/rdk-oe/meta-rdk/+/102382/2/recipes-common/rtremote/rtremote_git.bb. |
apatel859
reviewed
May 14, 2024
| @@ -868,6 +896,7 @@ static void gdial_rest_http_server_apps_callback(SoupServer *server, | |||
| gdial_rest_server_handle_OPTIONS(msg, "DELETE, OPTIONS"); | |||
| } | |||
| else if (msg->method == SOUP_METHOD_DELETE) { | |||
| refresh_app_state(app_name); | |||
There was a problem hiding this comment.
why we need refresh app state as in general we have state update callback from app to DAIL which should take care of updting the state.
There was a problem hiding this comment.
@apatel859 if app instances are created outside of xdial, we might
still be missing GDialApp instance.so we are using this function static gboolean refresh_app_state(const gchar *app_name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1)ARRISAPP-69 wait for application state responses (LibertyGlobal#16)
It is now possible to specify the amount of time
xdial server waits for rtremote status update resposes
with XDIAL_WAIT_FOR_RTREMOTE_STATE_RESPONSE_MS.
This can be used to make sure that up-to-date application
states are returned (instead of cached ones)
2)OMWAPPI-1342 xdial: create GDialApp if app exists (LibertyGlobal#23)
if app instances are created outside of xdial, we might
still be missing GDialApp instance.
do not fetch app state asynchronously in case
xdial is configured to wait for remote state responses
anyway
if current app state is 'stopped' or 'hidden'
always return 201 on POST requests
3)OMWAPPI-1360 introduce XDIAL_MAX_STATE_VALUE_AGE_MS (LibertyGlobal#24)
To limit synchronous app state polling (that takes time),
XDIAL_MAX_STATE_VALUE_AGE_MS env variable can be set to
specify how long the last state update is still
considered 'current'; until this time passes the last
cached state is returned and the remote state is not queried.
ONEMPERS-642: stop and hide results with 404 fixed (https://github.com/rdkcentral/xdialserver/pull/17)(rtcache.cpp)
cache objects marked as markUnevictable(, true) to not remove them from cache