-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sv keymap to include neighbouring nordic characters #208
base: master
Are you sure you want to change the base?
The head ref may contain hidden characters: "fix/sv-keymap-\u00E6\u00F8"
Conversation
The patch looks fine, and I was hoping to do a quick test and merge this, but I can't seem to write æøÆØ characters with this patch applied. No characters appear, although keyboard debug logging indicates that they're translated and sent to the server. I'm confused. Maybe someone with more insight into the keymap/input side of rdesktop can help? |
Thanks for looking at and attempting to merge my patch! For what it is worth, I have successfully been using this change since before I first posted it to rdesktop-devel in June. Yet only with rdesktop running on Linux connecting to VirtualBox hosts exposed through RDP. It is possible that I underestimate the complexity required to implement it properly for other environments. Even though I lack the understanding of rdesktop internals, I could try to help debugging what happens in other setups. What kind of RDP server were you connecting to when it did not work @derfian ? |
Windows 2016. I tried looking at the keyboard code in rdesktop, but it didn't alleviate my confusion. |
I've verified with a Windows server too now, and sure enough it does not work. Did some more debugging and read the doc/keymapping.txt properly. Think I understand the issue and should have a new patch to post shortly. |
Having looked a few more minutes at the issue, I quite confident that the patch is correct as it is. It is however insufficient in delivering everything needed for Windows hosts. Applying the patch still improves functionality for us connecting from unix to unix. Keystrokes are successfully sent if adding sequence-lines to the keymap file. For example adding "sequence oslash dead_diaeresis e" yields an ë for each press on ø, even on Windows. I can't figure out how to add a sequence that actually generates the desired characters though. Attempting combinations with dead_stroke, compose and Multi_key in them fails in different interesting ways. Maybe it is possible to fix, but maybe a fix requires patches on other levels. I'm giving up at getting this to work with Windows. |
As supported on virtually all other Swedish keyboard keymaps.
ef735d3
to
06e34a8
Compare
Branch rebased to current master. No other changes. |
As supported on virtually all other Swedish keyboard keymaps.