Finish NarBar #76
Open
Finish NarBar #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pictures as logos
|
Navbar looks great! |
and added stylesheet for modules component
…Source into WebpageReact
…nent (not needed), added script for collapsible table and updated module css
Displaying text here instead of putting Syllabus.md display in its own component to better follow react conventions
…mponent to module page
…Source into WebpageReact
(used online tool to convert markdown to html)
Also added comments to Syllabus.jsx and added a different homepage image
Create a new file called testRenderHTML.jsx to render a html file
I change back the codes to the before-debug status
Users don't have to zoom out to view the whole NavBar now.
On dark mode, the footer is white which contrasts with the dark mode background a lot. This commit adds a dark mode Footer which is the same color as the NavBar.
Changed "stuff" to "material" as it's just better wording, and cleaned up ModuleStyle.css a bit in trying to figure out why the collapsible icon isn't working.
Modules.jsx now uses the React-collapsible feature, which is a lot nicer and smoother.
Modules dropdowns now have working transitioning icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we finish the navBar development:
[1] We consider two cases, one is that students will browse our website using a laptop, and another is that students will browse our website using a cell phone. In the second case, the navbar will collapse to the side.
[2] We include 5 pages in the navbar such as Home, Syllabus, Modules, Assignments, and Discussion Forum.