Added DateIso8601 Support for Timestamp DataType #88
Conversation
|
Does it compile in both cdh4 and cdh5 ( mvn compile -Pcdh4) ? Some timestamp features were added in newer versions of hive. |
|
Yeah I tested it with (Hive 12 and CDH5) and (Hive 10 and CDH 4.5) and it Regards, On Fri, Sep 12, 2014 at 2:42 AM, Roberto Congiu notifications@github.com
Regards, |
|
Hey, will you merge this pull request or do you need any help to merge it? |
Empty string is deseralized as null timestamp
| } else if (s.indexOf('.') >= 0) { | ||
| } | ||
| else if(s.matches(datePattern)){ | ||
| value = new Timestamp(javax.xml.bind.DatatypeConverter.parseDate(s).getTimeInMillis()); |
There was a problem hiding this comment.
That's a funky dependency for parsing dates. I just merged another pull request for parsing timestamps, that can parse using SimpleDateFormat, check it out
|
It does now, I pushed a change on develop branch, check it out. -------------------------------------------------------
"Good judgment comes from experience.
Experience comes from bad judgment"
-------------------------------------------------------
On Saturday, August 19, 2017 10:04 AM, Siddharth Gupta <notifications@github.com> wrote:
does hive-json-serde support ISO timestamp?My json contains: 2017-08-17T10:46:04+0000
Hive table fieldType: timestampError: Caused by: java.lang.IllegalArgumentException: Timestamp format must be yyyy-mm-dd hh:mm:ss[.fffffffff]—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks a lot @rcongiu for quick turnaround! I'll check it out. |
Added mainly isodate8601 format support acceptance and few corrections around javaStringByteObjectInspector and javaStringDoubleObjectInspector.