feat: Add ability to clear notification history #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about this pull request? I would find this feature pretty useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
:NotificationsClearuser command and therequire("notify").clear_history()lua function to clear notification history.Details
The implementation simply resets the internal notification history table to an empty table. I am not sure how this interacts with any potential asynchronous activity, but I figured that if something is waiting to be pushed into the history table, it doesn't really matter for practical purposes if it gets pushed before or after the table is reset.
I added a documentation header in the code and I updated the readme to reflect the new command and new function.
Notes
Closes #158