- permit to cache Proxy authentication, and to combine with website authentication #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tinguish between a key from a request, and a key from a proxy object. - AuthenticationCacheInterceptor use a DefaultRequestCacheKeyProvider or DefaultProxyCacheKeyProvider, to get the right key. autCache is purged, depending if applied against a proxy or request object, AND the related response code. - Add DefaultProxyCacheKeyProvider - Rename DefaultCacheKeyProvider.java into DefaultRequestCacheKeyProvider - update doc to illustrate how to cache proxy authenticaiton (with NetworkInterceptor), and how to combine both authentications (proxy and web site).
rburgst
reviewed
Jul 24, 2023
There was a problem hiding this comment.
thanks a lot for your great contribution. I really appreciate it. Could you be so kind to add a new test case for the new features you introduced. As I dont have a test server with which I can replicate that it would take me quite a while to set everything up and come up with a realistic test case.
src/main/java/com/burgstaller/okhttp/DefaultProxyCacheKeyProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/burgstaller/okhttp/AuthenticationCacheInterceptor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/burgstaller/okhttp/AuthenticationCacheInterceptor.java
Outdated
Show resolved
Hide resolved
…der.java Co-authored-by: rburgst <rburgst@gmail.com>
…thentication failed.
add junit 5 'test' dependency. add wiremock 'test' dependency. add a 'test' block to allow junit5 use in gradle.
- basic authentication for proxy and basic authentication for web site - digest authentication for proxy and digest authentication for web site
…ion_in_the_same_time' into allow_proxy_and_site_authentication_in_the_same_time
|
@rburgst : i've updated the pull request based on your comments. Have you any feedback on this new submission ? Charles. |
rburgst
approved these changes
Aug 1, 2023
src/test/java/com/burgstaller/okhttp/AuthenticationCacheInterceptorTest.java
Show resolved
Hide resolved
added 3 commits
August 2, 2023 01:23
…ble and fix AuthenticationCacheInterceptorTest mockito content, and modernize assertions.
…ble and fix AuthenticationCacheInterceptorTest mockito content, and modernize assertions.
rburgst
approved these changes
Aug 3, 2023
clescot
deleted the
allow_proxy_and_site_authentication_in_the_same_time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal : permit to cache Proxy authentication, and to combine it with website authentication :
add to CacheKeyProvider the 'applyToProxy' method, to permit to distinguish between a key from a request, and a key from a proxy object.
AuthenticationCacheInterceptor use a DefaultRequestCacheKeyProvider or DefaultProxyCacheKeyProvider, to get the right key. autCache is purged, depending if applied against a proxy or request object, AND the related response code.
Add DefaultProxyCacheKeyProvider
Rename DefaultCacheKeyProvider.java into DefaultRequestCacheKeyProvider
update doc to illustrate how to cache proxy authenticaiton (with NetworkInterceptor), and how to combine both authentications (proxy and web site).