Don't suppress theme errors #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pain point I've had with resumed has been that as I develop my theme locally, resumed suppresses any error resulting from the import which *could* mean the theme isn't installed but it could also mean the theme failed to evaluate for another reason. NOTE: There are a couple `XXX` comments in which I explain the different outputs I'm seeing in test versus using resumed on the command line. I'm hoping to get a pointer on how to resolve this if this change is otherwise acceptable. NOTE: I'm committing with `git commit --no-verify` because I couldn't figure out how to get the pre-commit hook passing. Even though running `npm test` comes out green, vitest fails in the pre-commit hook with the same results I get if I run vitest without `FORCE_COLOR=0`. Some aspect of my environment must be wrong...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pain point I've had with resumed has been that as I develop my theme locally, resumed suppresses any error resulting from the import which could mean the theme isn't installed but it could also mean the theme failed to evaluate for another reason.
NOTE: There are a couple
XXXcomments in which I explain the different outputs I'm seeing in test versus using resumed on the command line. I'm hoping to get a pointer on how to resolve this if this change is otherwise acceptable.NOTE: I'm committing with
git commit --no-verifybecause I couldn't figure out how to get the pre-commit hook passing. Even though runningnpm testcomes out green, vitest fails in the pre-commit hook with the same results I get if I run vitest withoutFORCE_COLOR=0. Some aspect of my environment must be wrong...