feat(StepGroup): StepGroup Implementation & Documentation #2131
Conversation
|
|
✅ PR title follows Conventional Commits specification. |
saurabhdaware
requested review from
chaitanyadeorukhkar,
kamleshchandnani and
anuraghazra
as code owners
TODO: this comment is yet to be resolved. I'll check with design and resolve it. Rest comments are resolved |
saurabhdaware
added
Review - L2
| const useDottedLineStyles = ({ isHorizontal }: { isHorizontal?: boolean } = {}): BaseBoxProps => { | ||
| const { theme } = useTheme(); | ||
|
|
||
| const svgString = `<svg width="2" height="2" viewBox="0 0 2 2" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
pure css didn't work out?
There was a problem hiding this comment.
There isn't a way to shape the dot into circle. With pure CSS we can create a line with spaced but not exactly dots
| @@ -34,6 +34,8 @@ export const size = { | |||
| 28: 28, | |||
| /** 32 px */ | |||
| 32: 32, | |||
| /** 33 px */ | |||
There was a problem hiding this comment.
We're getting very specific now 😢
There was a problem hiding this comment.
Is this also on design?
There was a problem hiding this comment.
yup 😢 It needs to be exact because otherwise lines don't align
|
Add Changeset |
Will add it in tests PR #2134 Update: Added there |
Description
Additional Information
Preview: https://stepper-step-1--61c19ee8d3d282003ac1d81c.chromatic.com/?path=/story/components-stepgroup--step-group-default
Component Checklist