fix(Checkbox): stop unnecessary event delegation in checkbox #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandal97
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315 and
saurabhdaware
as code owners
|
|
✅ PR title follows Conventional Commits specification. |
5 tasks
anuraghazra
reviewed
Apr 12, 2024
Comment on lines
+244
to
+245
| <BaseBox onClick={(e) => e.stopPropagation()}> | ||
| <SelectorTitle size={_size} isDisabled={_isDisabled}> |
There was a problem hiding this comment.
Is it possible to have onClick on SelectorTitle itself instead of introducing a BaseBox wrapper?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Event Delegation occurs twice even if the Checkbox is clicked once. This can cause issues while implementing analytics as a single click might infer that the checkbox has been clicked twice. Also, due to this, table multi-select feature not working if we click on the checkbox.
Provided the issue link below for more details.
Changes
Stop propagation from all the child components of the
labelwrapper except theinputelement.Additional Information
#1978
Component Checklist