Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blade): scroll into view tab items when value changes #1868

Closed
wants to merge 9 commits into from

Conversation

anuraghazra
Copy link
Member

fixes #1857

Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 1f42d15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

bundlemon bot commented Dec 5, 2023

BundleMon

Files updated (1)
Status Path Size Limits
Web Components
build/components/index.production.web.js
331.89KB (+1.85KB +0.56%) -
Unchanged files (13)
Status Path Size Limits
React Native Components
build/components/index.native.js
187.05KB -
Web Tokens
build/tokens/index.production.web.js
42.24KB -
React Native Tokens
build/tokens/index.native.js
38.35KB -
CSS Theme Tokens
build/css/paymentThemeDarkDesktop.css
4.55KB -
CSS Theme Tokens
build/css/paymentThemeDarkMobile.css
4.54KB -
CSS Theme Tokens
build/css/bankingThemeLightDesktop.css
4.53KB -
CSS Theme Tokens
build/css/bankingThemeLightMobile.css
4.52KB -
CSS Theme Tokens
build/css/bankingThemeDarkDesktop.css
4.52KB -
CSS Theme Tokens
build/css/paymentThemeLightDesktop.css
4.52KB -
CSS Theme Tokens
build/css/bankingThemeDarkMobile.css
4.51KB -
CSS Theme Tokens
build/css/paymentThemeLightMobile.css
4.51KB -
Web Utils
build/utils/index.production.web.js
3.38KB -
React Native Utils
build/utils/index.native.js
2.27KB -

Total files change +1.85KB +0.29%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codesandbox-ci bot commented Dec 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f42d15:

Sandbox Source
razorpay/blade: basic Configuration

Copy link
Contributor

github-actions bot commented Dec 13, 2023

✅ PR title follows Conventional Commits specification.

saurabhdaware
saurabhdaware previously approved these changes Dec 19, 2023
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@saurabhdaware
Copy link
Member

On docs page, the tabs are always visible on top. Can you keep a note of this somewhere and fix it? we can merge this PR to unblock acquisition.

image

@saurabhdaware
Copy link
Member

Should clicking on Tab scroll you to that page in documentation example?

@anuraghazra
Copy link
Member Author

Should clicking on Tab scroll you to that page in documentation example?

No the consumer can handle that via onCLick

@anuraghazra
Copy link
Member Author

On docs page, the tabs are always visible on top. Can you keep a note of this somewhere and fix it? we can merge this PR to unblock acquisition.

Fixed.

@kamleshchandnani kamleshchandnani removed the request for review from snitin315 December 22, 2023 05:04
@kamleshchandnani kamleshchandnani marked this pull request as draft December 27, 2023 12:27
@saurabhdaware
Copy link
Member

@anuraghazra do we still want this PR? Looks a bit outdated now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to scroll into view for Tab Items
2 participants