Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config override #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Config override #74

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2017

Change Profile

Question Answer
New feature no
Bug fix yes
BC breaks no
Passing tests quick an dirty tested, passed

Description

The original config override didn't work the way as was provided in the Readme. After some research I found that the issue was that the custom config were loaded after the DOMPDFModule was loaded and merged. To fix this issue, a new key dompdf_module_override was introduced that can be placed in the application or module config an will be merged after the whole config was merged.

Reason

Needed to enable remote content, but wasn't able to do it.

@raykolbe raykolbe assigned raykolbe and ghost and unassigned raykolbe Dec 15, 2017
@raykolbe raykolbe self-requested a review December 15, 2017 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants