Update empty-screenshots extension #12358
Conversation
- Updates to preferences, functionality and language - Initial commit
raycastbot
added
the
extension fix / improvement
|
Thank you for your contribution! 🎉 🔔 @chanceaclark you might want to have a look. |
raycastbot
added
the
extension: empty-screenshots
|
|
New UI |
There was a problem hiding this comment.
Hey @robotdestroy thanks for contributing to this extension! I have a few comments regarding this change but overall I love this addition!
🍹 = Optional or discussion comments so feel free to disregard them if you feel passionately about it.
Additionally, I am about to get married/go on my honeymoon for the next two weeks so I won't be able to respond much after this message. After this review, I will defer the approval of this PR to the Raycast team or valid approver. Hopefully this doesn't impact the resolution time too much 🙏
Co-authored-by: Chancellor Clark <chancellorclark@gmail.com>
Co-authored-by: Chancellor Clark <chancellorclark@gmail.com>
Co-authored-by: Chancellor Clark <chancellorclark@gmail.com>
|
Is this ready for another review? |
|
Yup! |
|
|
||
| try { | ||
| const files = await readdir(folder); | ||
|
|
||
| const screenshots = files | ||
| .filter((file) => file.endsWith(".png") || file.endsWith(".mov")) | ||
| .filter((file) => | ||
| prefixString ? file.startsWith(prefixString) : file.startsWith("CleanShot") || file.startsWith("Screen"), |
There was a problem hiding this comment.
I just tried to change language to danish and the name here is Skærmbillede 2024-05-22 kl. 09.08.22.png - this will never be removed, so maybe it's better to do as before and only filter if custom prefixString has been set (which we could make to a comma seperated list)
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder