Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix test_actor_manager CI test. #45411

Merged
merged 1 commit into from
May 17, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented May 17, 2024

Fix test_actor_manager CI test.

  • Making timeout even more conservative.

The root cause of this test failing is that we are sending out 2x4 ray remote requests to 4 actors (methods "call()" and "ping()") through the ActorManager's async_req utility, which is nothing else other than making the ray remote call on the actors and returning the futures (Ray ObjRefs). Then we sleep, then do a ray.wait() to collect the results.

Any slowdowns here in the past are due to the actors' requests not being scheduled on time due to possibly other actors on the same node taking priority.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@can-anyscale
Copy link
Collaborator

the test_actor_manager, test_bc, etc. doesn't run on microcheck/premerge. because they are marked as flaky tests in this file https://github.com/ray-project/ray/blob/master/ci/ray_ci/rllib.tests.yml#L21. Maybe remove them from the file so that they can run on permerge, thankks

@sven1977 sven1977 enabled auto-merge (squash) May 17, 2024 14:06
@github-actions github-actions bot added the go Trigger full test run on premerge label May 17, 2024
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 merged commit eed322a into ray-project:master May 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Trigger full test run on premerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants