[RLlib] Fix test_actor_manager CI test. #45411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test_actor_manager CI test.
The root cause of this test failing is that we are sending out 2x4 ray remote requests to 4 actors (methods "call()" and "ping()") through the ActorManager's async_req utility, which is nothing else other than making the ray remote call on the actors and returning the futures (Ray ObjRefs). Then we sleep, then do a ray.wait() to collect the results.
Any slowdowns here in the past are due to the actors' requests not being scheduled on time due to possibly other actors on the same node taking priority.
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.