Run IPython shell without embedding #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrdadn
force-pushed
the
shell
branch
3 times, most recently
from
b8c57ef
to
4052d2b
Compare
mehrdadn
force-pushed
the
shell
branch
2 times, most recently
from
453f7f4
to
ad46184
Compare
mehrdadn
force-pushed
the
shell
branch
3 times, most recently
from
d72d476
to
6db20cf
Compare
|
This looks really good. It seems to do exactly what we want. Question, about the line IPython.terminal.ipapp.launch_new_instance(argv=main(sys.argv[1:]), user_ns=globals())Is this stable? The function I assume you found this by looking at the implementation of |
|
Yeah. I have no idea if it's stable, but it had documentation in the comments so I assumed it was semi stable. I'm not aware of a better way. |
pcmoritz
pushed a commit
to pcmoritz/ray
that referenced
this pull request
Dec 18, 2017
* Attempt to start web UI when starting Ray. * Add instructions for using web UI to cluster documentation. * Don't check if port 8080 is open. * Remove print statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around bug ipython/ipython#62 from 2010 which still hasn't been fixed.
Ready for merge.