Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle too many requests response #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle too many requests response #303

wants to merge 2 commits into from

Conversation

szkl
Copy link

@szkl szkl commented Mar 23, 2017

Fixes #110.

@gokmen
Copy link

gokmen commented Mar 23, 2017

@rauchg I didn't know that GH allows PR approvals without write access, sorry for the noise.

@iBobik
Copy link

iBobik commented Mar 27, 2017

When this will be released? It is worth of minor version, I thing.

@dustinmm80
Copy link

dustinmm80 commented Jul 14, 2017 •
edited

We just hit this today with our implementation. Is this being merged any time soon? I'd rather not have to fork the project. Thanks for your time.

screen shot 2017-07-14 at 1 30 46 pm

@szkl
Retry method can take an optional delay parameter
e029dc7 
Signed-off-by: Sönmez Kartal <szkl89@gmail.com>
@szkl
Handle too many requests response
c68fd42 
Signed-off-by: Sönmez Kartal <szkl89@gmail.com>
@emedvedev emedvedev mentioned this pull request Oct 30, 2017
Open
MichaelDaum added a commit to MichaelDaum/slackin that referenced this pull request Nov 14, 2017
@MichaelDaum
cherry-picked fix for issue rauchg#303
3700800
@lvnilesh
Copy link
Contributor

This PR resolved the issue #110

@lvnilesh lvnilesh mentioned this pull request Feb 23, 2018
Open
@alranel
Copy link

alranel commented Jan 15, 2019

This PR seems to fix the issue for me as well. I think merging it wouldn't hurt!

@maxdanilov
Copy link

@rauchg any ETA on when this will be released?

@loleg
Copy link

loleg commented Apr 17, 2020

Bump. This is a basic issue that is not visible to users but potentially affects end-users.

@loleg loleg mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gokmen gokmen gokmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Invalid Slack response
8 participants
@szkl @gokmen @iBobik @dustinmm80 @lvnilesh @alranel @maxdanilov @loleg