Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade guice 7.0 #1707

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ext {
dropwizardMetrics: "4.2.21",
groovy : "3.0.9", // Gradle 7.4 uses Groovy 3.0.9
guava : "31.1-jre",
guice : "5.1.0",
guice : "7.0.0",
jackson : "2.13.3",
javassist : "3.29.0-GA",
log4j : "2.17.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ default RatpackServerSpec serverConfig(Action<? super ServerConfigBuilder> actio
* import ratpack.core.handling.Handler;
* import ratpack.test.embed.EmbeddedApp;
*
* import javax.inject.Inject;
* import jakarta.inject.Inject;
*
* import static org.junit.jupiter.api.Assertions.assertEquals;
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
* import ratpack.core.service.StopEvent;
* import ratpack.guice.Guice;
* import ratpack.func.Types;
* import javax.inject.Inject;
* import jakarta.inject.Inject;
*
* import java.util.List;
* import java.util.LinkedList;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import com.codahale.metrics.jvm.MemoryUsageGaugeSet;
import com.codahale.metrics.jvm.ThreadStatesGaugeSet;
import com.google.inject.Injector;
import com.google.inject.Provider;
import jakarta.inject.Provider;
import com.google.inject.matcher.Matchers;
import com.google.inject.multibindings.Multibinder;
import io.netty.buffer.ByteBufAllocator;
Expand All @@ -43,7 +43,7 @@
import ratpack.core.service.StartEvent;
import ratpack.core.service.StopEvent;

import javax.inject.Inject;
import jakarta.inject.Inject;

import java.util.ArrayList;
import java.util.Collections;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.Reporter;
import com.google.inject.Provider;
import jakarta.inject.Provider;
import ratpack.dropwizard.metrics.DropwizardMetricsConfig;
import ratpack.dropwizard.metrics.ReporterConfigSupport;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
import ratpack.dropwizard.metrics.BlockingExecTimingInterceptor;
import ratpack.dropwizard.metrics.DropwizardMetricsConfig;

import javax.inject.Inject;
import javax.inject.Provider;
import jakarta.inject.Inject;
import jakarta.inject.Provider;

/**
* Provide a timer for blocking executions.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import ratpack.dropwizard.metrics.ConsoleConfig;
import ratpack.dropwizard.metrics.DropwizardMetricsConfig;

import javax.inject.Inject;
import jakarta.inject.Inject;

/**
* A Provider implementation that sets up a {@link ConsoleReporter} for a {@link MetricRegistry}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import ratpack.dropwizard.metrics.CsvConfig;
import ratpack.dropwizard.metrics.DropwizardMetricsConfig;

import javax.inject.Inject;
import jakarta.inject.Inject;

/**
* A Provider implementation that sets up a {@link CsvReporter} for a {@link MetricRegistry}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.inject.Inject;
import jakarta.inject.Inject;
import java.lang.reflect.Method;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import ratpack.dropwizard.metrics.DropwizardMetricsConfig;
import ratpack.dropwizard.metrics.GraphiteConfig;

import javax.inject.Inject;
import jakarta.inject.Inject;

/**
* A Provider implementation that sets up a {@link GraphiteReporter} for a {@link MetricRegistry}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import ratpack.dropwizard.metrics.DropwizardMetricsConfig;
import ratpack.dropwizard.metrics.JmxConfig;

import javax.inject.Inject;
import jakarta.inject.Inject;

/**
* A Provider implementation that sets up a {@link JmxReporter} for a {@link MetricRegistry}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;

import javax.inject.Inject;
import jakarta.inject.Inject;
import java.lang.reflect.Method;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import ratpack.exec.ExecController;
import ratpack.exec.stream.internal.PeriodicPublisher;

import javax.inject.Inject;
import jakarta.inject.Inject;
import java.time.Duration;

public class MetricRegistryPeriodicPublisher extends PeriodicPublisher<MetricRegistry> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import com.codahale.metrics.MetricRegistry;
import ratpack.exec.stream.internal.MulticastPublisher;

import javax.inject.Inject;
import jakarta.inject.Inject;

/**
* A message broadcaster for sending metrics to its subscribers.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
import ratpack.dropwizard.metrics.RequestTimingHandler;
import ratpack.core.handling.Context;

import javax.inject.Inject;
import javax.inject.Provider;
import jakarta.inject.Inject;
import jakarta.inject.Provider;

/**
* Provide an instance of a request timing handler.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import ratpack.dropwizard.metrics.DropwizardMetricsConfig;
import ratpack.dropwizard.metrics.Slf4jConfig;

import javax.inject.Inject;
import jakarta.inject.Inject;

/**
* A Provider implementation that sets up a {@link Slf4jReporter} for a {@link MetricRegistry}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import org.aopalliance.intercept.MethodInvocation;
import ratpack.exec.Promise;

import javax.inject.Inject;
import jakarta.inject.Inject;
import java.lang.reflect.Method;
import java.util.concurrent.TimeUnit;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@ protected <O> Iterable<O> transformToInstances(Iterable<? extends Supplier<O>> s
}

protected <T> Iterable<? extends Supplier<T>> getSuppliers(TypeToken<T> type) {
Iterable<? extends Supplier<?>> suppliers = compute(supplierCache, type, t ->
registryBacking.provide(type)
);
Iterable<? extends Supplier<?>> suppliers = compute(supplierCache, type, t -> registryBacking.provide(type));
return Types.cast(suppliers);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

import groovy.sql.Sql;

import javax.inject.Inject;
import javax.inject.Provider;
import jakarta.inject.Inject;
import jakarta.inject.Provider;
import javax.sql.DataSource;

public class SqlProvider implements Provider<Sql> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import ratpack.core.render.Renderer;
import ratpack.core.server.ServerConfig;

import javax.inject.Singleton;
import jakarta.inject.Singleton;
import java.nio.file.Path;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import ratpack.core.handling.Context;
import ratpack.core.render.RendererSupport;

import javax.inject.Inject;
import jakarta.inject.Inject;
import java.io.IOException;
import java.io.OutputStream;
import java.io.OutputStreamWriter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import ratpack.core.handling.Context;
import ratpack.core.render.RendererSupport;

import javax.inject.Inject;
import jakarta.inject.Inject;

public class TextTemplateRenderer extends RendererSupport<TextTemplate> {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import ratpack.config.FileSystemBinding;
import ratpack.groovy.script.internal.ScriptEngine;

import javax.inject.Inject;
import jakarta.inject.Inject;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.nio.file.Files;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ class GroovyScriptAppSpec extends RatpackGroovyScriptAppSpec {
import ratpack.groovy.Groovy.Ratpack

import org.slf4j.*
import javax.inject.Inject
import jakarta.inject.Inject
import groovy.util.logging.*

final Logger log = LoggerFactory.getLogger(Ratpack)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import com.google.common.reflect.TypeToken;
import com.google.inject.Binder;
import com.google.inject.Module;
import com.google.inject.Provider;
import jakarta.inject.Provider;
import com.google.inject.TypeLiteral;
import com.google.inject.multibindings.Multibinder;
import ratpack.func.Action;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
import com.google.common.reflect.TypeToken;
import com.google.inject.AbstractModule;
import com.google.inject.Provides;
import jakarta.inject.Singleton;
import ratpack.config.ConfigObject;
import ratpack.func.Action;
import ratpack.func.Factory;
import ratpack.core.server.ServerConfig;
import ratpack.func.Action;
import ratpack.func.Exceptions;
import ratpack.func.Factory;
import ratpack.func.Types;

import javax.inject.Singleton;
import java.lang.reflect.Constructor;

/**
Expand Down
4 changes: 2 additions & 2 deletions ratpack-guice/src/main/java/ratpack/guice/Guice.java
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@
* import ratpack.core.handling.Handler;
* import ratpack.test.embed.EmbeddedApp;
*
* import javax.inject.Inject;
* import javax.inject.Singleton;
* import jakarta.inject.Inject;
* import jakarta.inject.Singleton;
*
* import static org.junit.jupiter.api.Assertions.*;
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,15 @@

import com.google.common.collect.ImmutableList;
import com.google.common.reflect.TypeToken;
import com.google.inject.*;
import com.google.inject.Binding;
import com.google.inject.Injector;
import com.google.inject.Key;
import com.google.inject.TypeLiteral;
import jakarta.inject.Provider;
import ratpack.func.Action;
import ratpack.func.Function;
import ratpack.func.internal.TypeCaching;
import ratpack.func.Types;
import ratpack.func.internal.TypeCaching;

import java.util.Map;
import java.util.concurrent.ConcurrentMap;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import com.google.common.collect.ImmutableList;
import com.google.common.reflect.TypeToken;
import com.google.inject.Injector;
import com.google.inject.Provider;
import jakarta.inject.Provider;
import ratpack.exec.registry.RegistryBacking;

public class InjectorRegistryBacking implements RegistryBacking {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,20 @@
import com.google.common.collect.Iterables;
import com.google.common.reflect.TypeToken;
import com.google.inject.*;
import com.google.inject.matcher.AbstractMatcher;
import com.google.inject.matcher.Matcher;
import com.google.inject.matcher.Matchers;
import io.netty.buffer.ByteBufAllocator;
import org.aopalliance.intercept.MethodInterceptor;
import ratpack.exec.api.Blocks;
import ratpack.config.FileSystemBinding;
import ratpack.core.error.ClientErrorHandler;
import ratpack.core.error.ServerErrorHandler;
import ratpack.exec.ExecController;
import ratpack.exec.ExecInitializer;
import ratpack.exec.Execution;
import ratpack.config.FileSystemBinding;
import ratpack.core.file.MimeTypes;
import ratpack.core.file.internal.FileRenderer;
import ratpack.core.form.internal.FormParser;
import ratpack.guice.ExecutionScoped;
import ratpack.guice.RequestScoped;
import ratpack.core.handling.Redirector;
import ratpack.core.http.Request;
import ratpack.core.http.Response;
import ratpack.core.http.client.HttpClient;
import ratpack.exec.registry.Registry;
import ratpack.core.render.internal.CharSequenceRenderer;
import ratpack.core.render.internal.PromiseRenderer;
import ratpack.core.render.internal.PublisherRenderer;
Expand All @@ -49,6 +42,13 @@
import ratpack.core.server.RatpackServer;
import ratpack.core.server.ServerConfig;
import ratpack.core.sse.client.ServerSentEventClient;
import ratpack.exec.ExecController;
import ratpack.exec.ExecInitializer;
import ratpack.exec.Execution;
import ratpack.exec.api.Blocks;
import ratpack.exec.registry.Registry;
import ratpack.guice.ExecutionScoped;
import ratpack.guice.RequestScoped;

import java.lang.reflect.Method;
import java.util.List;
Expand Down Expand Up @@ -169,7 +169,7 @@ public <T> void doAdd(Execution execution, Key<T> key) {
}
}

private static class NotGroovyMethodMatcher extends AbstractMatcher<Method> {
private static class NotGroovyMethodMatcher implements Matcher<Method> {
@Override
public boolean matches(Method method) {
return !method.isSynthetic();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package ratpack.guice
import com.google.inject.AbstractModule
import ratpack.test.internal.RatpackGroovyDslSpec

import javax.inject.Provider
import jakarta.inject.Provider

class BindingsSpecSpec extends RatpackGroovyDslSpec {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import ratpack.core.service.Service
import ratpack.core.service.StartEvent
import ratpack.test.internal.RatpackGroovyDslSpec

import javax.inject.Inject
import jakarta.inject.Inject

class GuiceLifecycleEventSpec extends RatpackGroovyDslSpec {

Expand Down