feat(canvas)!: add fill property to Circle #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original algorithm may cause holes when the circle is large
BREAKING CHANGE: `Circle` now has a `fill` field. Set as `false` for original behavior.
SOF3
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
======================================
Coverage 92.0% 92.0%
======================================
Files 61 61
Lines 15493 15630 +137
======================================
+ Hits 14259 14391 +132
- Misses 1234 1239 +5 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Circlenow has a fill field. Set as false for original behavior.Includes changes from #917 to reuse the step_points util