feat: Adds message to assert_buffer_eq! ✨
#849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdheepak
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka and
Valentin271
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=======================================
- Coverage 92.4% 91.0% -1.5%
=======================================
Files 61 61
Lines 16262 16262
=======================================
- Hits 15042 14809 -233
- Misses 1220 1453 +233 ☔ View full report in Codecov by Sentry. |
joshka
reviewed
Jan 19, 2024
Comment on lines
-49
to
+52
| assert_eq!(actual, expected, "buffers not equal"); | ||
| assert_eq!(actual, expected, $message); |
There was a problem hiding this comment.
This is just the fall through case (in case we didn't already fail for not equal buffers). The main failures will occur on lines 10 and 35.
|
I close this in favor of #1007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier for debugging.