Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): Simplify scrollbar example #1078

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marianomarciello
Copy link
Contributor

This PR simplifies the scrollbar example.
Divide the function ui into multiple functions such that clippy does not throw the clippy::too_many_lines error anymore.
Handle correctly the cast from usize to u16.

fix #975

…ller functions

Avoid clippy to triggers the "clippy::too_many_lines" error
Avoid clippy to triggers the "clippy::cast_possible_truncation" error
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.4%. Comparing base (f4637d4) to head (c82cf6f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1078   +/-   ##
=====================================
  Coverage   89.4%   89.4%           
=====================================
  Files         61      61           
  Lines      15468   15468           
=====================================
  Hits       13839   13839           
  Misses      1629    1629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kdheepak kdheepak changed the title Simplify scrollbar example docs(examples): Simplify scrollbar example May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify scrollbar example code
1 participant