Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add is_at_start and is_at_end methods #1024

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DeflateAwning
Copy link

Fixes #1018.

This is still a work in progress. Looking for help/feedback with the tests.

For this to work reliably and as expected, I believe that the Scroll object needs to "write back" to this ScrollbarState object, so that this ScrollbarState understands its viewport size. This communication is at the heart of most of the scrollbar deficiencies, as far as I can tell.

@DeflateAwning DeflateAwning changed the title Add is_at_start and is_at_end methods feat: Add is_at_start and is_at_end methods Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.4%. Comparing base (b7778e5) to head (7242b2b).

Files Patch % Lines
src/widgets/scrollbar.rs 66.6% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1024   +/-   ##
=====================================
  Coverage   89.4%   89.4%           
=====================================
  Files         61      61           
  Lines      15430   15434    +4     
=====================================
+ Hits       13799   13803    +4     
  Misses      1631    1631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ScrollbarState.is_at_start(), ScrollbarState.is_at_end() methods
1 participant