Add mixin methods to MemoryDataset #2871
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the mixin methods to make it more dataset-like.
|
@groutr I'm catching up on your PRs this week. I'm not ready to bring MemoryDataset to the surface yet and I think we should have more discussion before we do. It only exists because of GDAL API requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base implementation of MemoryDataset lacks transform and window methods. There are some places in rasterio where Datasets are assumed to have these kinds of methods. This PR adds those mixin methods and exposes MemoryDataset via rasterio.io.
@sgillies Is exposing MemoryDataset like this something we want to do?