Rebuild node-sass after yarn install #1946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Occasionally, CI builds will fail because
node-sass
is missing the linux binding in thevendor
directory:The official solution for this issue is to run
npm rebuild node-sass
, as documented in sass/node-sass#1579. This comment suggests a yarnpostinstall
step to rebuildnode-sass
, which is the approach I took in this PR.Checklist
- [ ] Styleguide updated, if necessary- [ ] Swagger specification updated, if necessary- [ ] Symlinks from new migrations present or corrected for any new migrationsDemo
N/A
Notes
Another potential option was to install the missing binary directly, as explained here. I felt that this was too hacky, and didn't fit as cleanly into the
cibuild
process.Testing Instructions
Closes #1385