Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump slim from 3.0.9 to 5.1.1 #2979

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 12, 2023

Bumps slim from 3.0.9 to 5.1.1.

Release notes

Sourced from slim's releases.

v5.1.1

  • Support lambda functions as shortcuts - #677 #813 #903
  • Support --enable-frozen-string-literal - #851

v5.1.0

Version 5.1.0

v5.0.0

No release notes provided.

v4.0.1

No release notes provided.

v4.0.0

No release notes provided.

Changelog

Sourced from slim's changelog.

5.1.1 (2023-05-16)

  • Support lambda functions as shortcuts - #677 #813 #903
  • Support --enable-frozen-string-literal - #851

5.1.0 (2023-03-06)

  • Allow whitespace markers for verbatim text: |<, |>, and |<> - #912
  • Do not swallow single quote after output line indicator - #911
  • Support Tilt 2.1.0 - #910
  • Fix Railtie load error - #904
  • Fix attribute parsing with square brackets - #796

5.0.0 (2023-01-23)

  • Fix markdown interpolation #773
  • Support case/in #884
  • Extract slim/railtie #850
  • css: doesn't add type='text/css' anymore #828
  • Remove deprecated whitespace syntax =' etc
  • Add support for annotate_rendered_view_with_filenames #867, #878, #901
  • Remove deprecated syntax
  • Add option to hyphenate underscore attributes - #852
  • Update CI/CD testing and dependencies

4.1.0 (2020-05-07)

  • Add support for Tailwind CSS - #841
  • Update dependencies and testing

4.0.1 (2018-09-02)

  • Fix incompatibility issue with Slim Include plugin and new ability to specifiy attributes for embedded engines #819

4.0.0 (2018-08-26)

  • Add ability to specify attributes for embedded engines using TagEngine - #653
  • Set Tilt's default encoding to utf-8 - #800
  • Prevent generation of invalid Ruby code in heredoc - #770
  • Don't convert underscores to dashes on data attributes - #807 [Backward incompatible]
  • Update description in README.jp.md - #795
  • Removed support for embedded engines: Asciidoc, Builder, Creole, Erb, Nokogiri, Opal, Org-Ruby, Styl, Wikicloth
  • Fix tests
Commits
  • a1df779 Version 5.1.1
  • a9db847 Relax Tilt version constraints
  • abf07b3 test.yml: Reduce cron runs
  • 99b4c71 Reenable scheduled tests
  • e02a8d5 Fix Intermittent test failures #845 (#919)
  • fa0395b test.yml: Disable scheduled tests for now
  • 0fb05fc Revert "Document that Slim must be required when used with Tilt (Fix #918)"
  • eddeb83 Document that Slim must be required when used with Tilt (Fix #918)
  • 206c6ad Update changelog
  • e1b66cc Ensure that tests work with --enable-frozen-string-literal
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jun 12, 2023
@lurch
Copy link
Contributor

lurch commented Jun 13, 2023

ping @nelliemckesson (why such a big version-jump?)

@lurch lurch added the toolchain This is an infrastructure/toolchain issue label Jun 13, 2023
@aallan
Copy link
Contributor

aallan commented Jun 13, 2023

This feels like a dangerous one! ☠️

@aallan aallan added the waiting for comment Awaiting a response label Jun 13, 2023
Bumps [slim](https://github.com/slim-template/slim) from 3.0.9 to 5.1.1.
- [Release notes](https://github.com/slim-template/slim/releases)
- [Changelog](https://github.com/slim-template/slim/blob/main/CHANGES)
- [Commits](slim-template/slim@v3.0.9...v5.1.1)

---
updated-dependencies:
- dependency-name: slim
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/develop/slim-5.1.1 branch from 80641d8 to 0987ead Compare June 13, 2023 08:31
@aallan
Copy link
Contributor

aallan commented Jun 21, 2023

...and it fails the build test. Umm. 😱

@lurch lurch marked this pull request as draft June 21, 2023 15:56
@lurch
Copy link
Contributor

lurch commented Jun 21, 2023

...and it fails the build test.

Converted this PR to draft, to prevent it getting merged accidentally.

@lurch
Copy link
Contributor

lurch commented Jun 21, 2023

@nelliemckesson It's got much further, but CI is now failing with a different error.

@nelliemckesson
Copy link
Contributor

@lurch yeah I saw -- I was getting annoyed so I had to go look at something else for a while.

@nelliemckesson
Copy link
Contributor

Ok the issue appears to be that the linux version of one of our gems requires specific versions on both bundler and rubygems -- should be fixed now?

@aallan
Copy link
Contributor

aallan commented Jun 22, 2023

This won't cause a problem with Mac though? I'm assuming if it works for @nelliemckesson it'll work on Mac? 😁

@aallan aallan marked this pull request as ready for review June 22, 2023 09:17
Copy link
Contributor

@aallan aallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming I can still build the docs on Mac as well as the pipeline running in a VM on Linux, we're good to go?

@aallan aallan merged commit 473c1b7 into develop Jun 22, 2023
1 check passed
@aallan aallan deleted the dependabot/bundler/develop/slim-5.1.1 branch June 22, 2023 11:14
@nelliemckesson
Copy link
Contributor

@aallan (just confirming that i did test locally and all was fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code toolchain This is an infrastructure/toolchain issue waiting for comment Awaiting a response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants