-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump slim from 3.0.9 to 5.1.1 #2979
Conversation
ping @nelliemckesson (why such a big version-jump?) |
This feels like a dangerous one! ☠️ |
Bumps [slim](https://github.com/slim-template/slim) from 3.0.9 to 5.1.1. - [Release notes](https://github.com/slim-template/slim/releases) - [Changelog](https://github.com/slim-template/slim/blob/main/CHANGES) - [Commits](slim-template/slim@v3.0.9...v5.1.1) --- updated-dependencies: - dependency-name: slim dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
80641d8
to
0987ead
Compare
...and it fails the build test. Umm. 😱 |
Converted this PR to draft, to prevent it getting merged accidentally. |
@nelliemckesson It's got much further, but CI is now failing with a different error. |
@lurch yeah I saw -- I was getting annoyed so I had to go look at something else for a while. |
Ok the issue appears to be that the linux version of one of our gems requires specific versions on both bundler and rubygems -- should be fixed now? |
This won't cause a problem with Mac though? I'm assuming if it works for @nelliemckesson it'll work on Mac? 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming I can still build the docs on Mac as well as the pipeline running in a VM on Linux, we're good to go?
@aallan (just confirming that i did test locally and all was fine) |
Bumps slim from 3.0.9 to 5.1.1.
Release notes
Sourced from slim's releases.
Changelog
Sourced from slim's changelog.
Commits
a1df779
Version 5.1.1a9db847
Relax Tilt version constraintsabf07b3
test.yml: Reduce cron runs99b4c71
Reenable scheduled testse02a8d5
Fix Intermittent test failures #845 (#919)fa0395b
test.yml: Disable scheduled tests for now0fb05fc
Revert "Document that Slim must be required when used with Tilt (Fix #918)"eddeb83
Document that Slim must be required when used with Tilt (Fix #918)206c6ad
Update changeloge1b66cc
Ensure that tests work with --enable-frozen-string-literalDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)