[REVIEW] string conversion for duration types (to_durations, from_durations) #5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
2 - In Progress
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
karthikeyann
changed the title
15 tasks
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #5625 +/- ##
===============================================
+ Coverage 86.12% 86.14% +0.01%
===============================================
Files 76 75 -1
Lines 12757 12715 -42
===============================================
- Hits 10987 10953 -34
+ Misses 1770 1762 -8
Continue to review full report at Codecov.
|
davidwendt
requested changes
Jul 27, 2020
karthikeyann
added
3 - Ready for Review
karthikeyann
requested review from
codereport,
raydouglass,
davidwendt,
jrhemstad and
kkraus14
davidwendt
reviewed
Jul 27, 2020
raydouglass
approved these changes
Jul 27, 2020
davidwendt
requested changes
Jul 28, 2020
davidwendt
approved these changes
Jul 28, 2020
karthikeyann
added
the
4 - Needs Review
harrism
requested changes
Jul 30, 2020
| } | ||
| bool is_negative = (value < 0); | ||
|
|
||
| char digits[MAX_DIGITS] = {'0', '0', '0', '0', '0', '0', '0', '0', '0', '0'}; |
There was a problem hiding this comment.
If this becomes a problem, profile it and see if putting it in shared memory (10 bytes per thread, not actually shared) helps performance. Might need to pad it out to avoid shmem bank conflicts.
harrism
approved these changes
Aug 3, 2020
17 tasks
|
@codereport @jrhemstad requesting for re-review |
karthikeyann
added
the
5 - Ready to Merge
karthikeyann
dismissed
jrhemstad’s stale review
for unblocking PR #5781 (also already addressed all review comments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses part of #5272
duration string support to_string API