Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS style is not using Lucario colors #60

Open
folixg opened this issue Jun 29, 2019 · 3 comments
Open

CSS style is not using Lucario colors #60

folixg opened this issue Jun 29, 2019 · 3 comments

Comments

@folixg
Copy link
Contributor

folixg commented Jun 29, 2019

The color codes in the CSS style are not the ones defined for lucario in the README.
For example for strings #d7d787is used instead of #e6db74. Is this done on purpose?
@raphamorim
Copy link
Owner

raphamorim commented Jul 1, 2019 •
edited

Is this done on purpose?

Hm, I don't think so. This is definitely wrong. Do you mind to send a PR to fix it @folixg?

@folixg
Copy link
Contributor Author

folixg commented Jul 1, 2019

I will try to find the time. I am not much of a HTML/CSS guy so I will need to figure out, how to test it.
@sduff would you mind fixing it?

@folixg
Copy link
Contributor Author

folixg commented Jul 9, 2019

Somehow in 7274db6 the complete color scheme got changed, so probably reverting the changes to CSS/lucario.css would fix it. However, I still have no idea, how I would test that.

@folixg folixg mentioned this issue Aug 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raphamorim @folixg