Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different editors/terminals use different colors #65

Open
folixg opened this issue Aug 7, 2019 · 1 comment
Open

Different editors/terminals use different colors #65

folixg opened this issue Aug 7, 2019 · 1 comment

Comments

@folixg
Copy link
Contributor

folixg commented Aug 7, 2019

After stumbling upon non-palette colors in #60 and #63, I just ran a quick grep over the files in this repository to get an overview of all color hex-codes used.

Here is a list of the files that include RGB color codes and the colors they use:

readme.md
#19242f
#243443
#2b3e50
#5c98cd
#e6db74
#f8f8f2

lucario.tmtheme
#10171e
#19242f
#243443
#2b3e50
#3f9ab7
#49483e
#5c98cd
#61bbc8
#66d9ef
#72c05d
#75715e
#a6e22e
#ae81ff
#e6db74
#f8f8f0
#f8f8f2
#f92672
#ca94ff
#ff6541
#ffab28

gnome-terminal/lucario.sh
#2b3e50
#4f4f4f
#5796ed
#6b9fed
#8ee478
#eeeeee
#f8f8f2
#fa6960
#fbb036
#fc6ffa
#feffb9
#ff6c60
#ff73fd
#ffffb6
#ffffff

styles/colors.less
#19242f
#199c4b
#243443
#2b3e50
#5c98cd
#66d9ef
#6be5fd
#72cc5a
#8be0fd
#ca94ff
#e6db74
#e94b35
#f0cc04
#f8f8f0
#f8f8f2
#ff6541
#ffab28

styles/syntax-variables.less
#2196f3
#263238
#65737e
#96cbfe
#a8ff60
#cc6666
#cdd3de
#e9c062
#c0c5ce

css/lucario.css
#2b3e50
#7ce5e6
#84dffe
#b3d6b3
#d7d787
#e6b5ff
#f8f8f2
#ffb3b5
#ffffcc

xfce4-terminal/lucario.theme
#2b3e50
#4f4f4f
#5796ed
#6b9fed
#8ee478
#e6db74
#eeeeee
#f8f8f2
#fa6960
#fbb036
#fc6ffa
#feffb9
#ff6c60
#ff73fd
#ffffb6
#ffffff

colors/lucario.vim
#19242f
#204a87
#26446c
#2b3e50
#354758
#405160
#478815
#5c98cd
#61bbc8
#66747f
#66d9ef
#72c05d
#8c0c10
#929ba1
#ca94ff
#e6db74
#f8f8f0
#f8f8f2
#f92672
#ff6541
#ffab28

termux/lucario.colors
#2b3e50
#4f4f4f
#5796ed
#6b9fed
#8ee478
#e3bf21
#eeeeee
#f8f8f2
#fa6960
#fbb036
#fc6ffa
#feffb9
#ff6c60
#ff73fd
#ffffb6
#ffffff

Comparing the colors used in the different implementations of the theme, it turns out that the default foreground and background colors are the only ones that are used in all implementations. The following table gives for each color the number of files it was found in.

Color Count
#10171e 1
#19242f 4
#199c4b 1
#204a87 1
#2196f3 1
#243443 3
#263238 1
#26446c 1
#2b3e50 8
#354758 1
#3f9ab7 1
#405160 1
#478815 1
#49483e 1
#4f4f4f 3
#5796ed 3
#5c98cd 4
#61bbc8 2
#65737e 1
#66747f 1
#66d9ef 3
#6b9fed 3
#6be5fd 1
#72c05d 2
#72cc5a 1
#75715e 1
#7ce5e6 1
#84dffe 1
#8be0fd 1
#8c0c10 1
#8ee478 3
#929ba1 1
#96cbfe 1
#a6e22e 1
#a8ff60 1
#ae81ff 1
#b3d6b3 1
#c0c5ce 1
#ca94ff 3
#cc6666 1
#cdd3de 1
#d7d787 1
#e3bf21 1
#e6b5ff 1
#e6db74 5
#e94b35 1
#e9c062 1
#eeeeee 3
#f0cc04 1
#f8f8f0 3
#f8f8f2 8
#f92672 2
#fa6960 3
#fbb036 3
#fc6ffa 3
#feffb9 3
#ff6541 3
#ff6c60 3
#ff73fd 3
#ffab28 3
#ffb3b5 1
#ffffb6 3
#ffffcc 1
#ffffff 3

In order to make the Lucario color theme more consistent across different Editors/Terminals, I think there are two steps to be taken:

  1. Expand the "official" color palette. I mean all of the above listed implementations use more than the 6 basic colors and providing more "official" colors would reduce the clutter. For example it might make sense to define a 16-color palette that can be used by terminal schemes in conjunction with the foreground and background color.

  2. Overhaul all implementations so that they use only colors from the expanded color palette.

I really like the overall looks of lucario and I use it for several applications and I would love it to be more consistent, so I'd be willing to invest some time on this issue. However, I don't think I would be much help when it comes to expanding the color palette, but I could definitely help out updating the different implementations.

Sorry for the lengthy issue, looking forward to hear your opinion on this topic.

@kdb13
Copy link
Contributor

kdb13 commented Sep 9, 2020

I support changing the official color palette to include all the necessary colors. Once the official color pallete is complete, I will also change my termux implementation to be consistent with this new palette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants